Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated dependency in jdbc-test module #3664

Merged
merged 1 commit into from Jan 10, 2021
Merged

Remove duplicated dependency in jdbc-test module #3664

merged 1 commit into from Jan 10, 2021

Conversation

giger85
Copy link
Contributor

@giger85 giger85 commented Jan 4, 2021

In jdbc-test module, commons-dbutils:commons-dbutils:1.7 is duplicated.
So removes second one.

rnorth
rnorth approved these changes Jan 10, 2021
View reviewed changes
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot @giger85
Must have been a copy-and-paste error - thanks for fixing!

@rnorth rnorth merged commit d96dd81 into testcontainers:master Jan 10, 2021
This was referenced Mar 13, 2021
Open
Merged
Closed
Merged
Merged
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@bsideup bsideup Awaiting requested review from bsideup

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
type/housekeeping type/test-improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@giger85 @rnorth