Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Presto image hosted on GHCR #3667

Conversation

findepi
Copy link
Contributor

@findepi findepi commented Jan 6, 2021

The prestosql Docker Hub org has been deprecated and the current
Presto image has been moved to GitHub Container Registry.

The `prestosql` Docker Hub org has been deprecated and the current
Presto image has been moved to GitHub Container Registry.
@findepi
Copy link
Contributor Author

findepi commented Jan 6, 2021

cc @martint

@findepi
Copy link
Contributor Author

findepi commented Jan 6, 2021

cc @losipiuk

@bsideup
Copy link
Member

bsideup commented Feb 6, 2021

@findepi I guess it is super-seeded by #3668? :)

@findepi
Copy link
Contributor Author

findepi commented Feb 6, 2021

@bsideup thanks for your review.
Unless you intend to follow #3668 along with removal of PrestoContainer class, I think this PR remains relevant.

@bsideup
Copy link
Member

bsideup commented Feb 7, 2021

@findepi oh, sorry, I think I got confused. I thought you renamed Presto to Trino, and now Presto is FB's "fork", with their own images? Or you host both?

@findepi
Copy link
Contributor Author

findepi commented Feb 8, 2021

@bsideup the PrestoContainer is a container based on Presto SQL's image.
This image is being moved from docker hub's prestosql/presto to ghcr.io/trinodb/presto and kept for archival purposes. No further releases of the image are expected.

@bsideup bsideup added this to the next milestone Feb 10, 2021
@bsideup bsideup merged commit b0f1bbc into testcontainers:master Feb 10, 2021
@findepi findepi deleted the findepi/switch-to-presto-image-hosted-on-ghcr-a1278d branch February 11, 2021 22:21
@findepi
Copy link
Contributor Author

findepi commented Feb 11, 2021

Thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants