doc: Update logback-test.xml example to show how to enable DEBUG only for Testcontainers #5976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are other instances of |
|
Thanks for the PR @edysli. The other instances are what is the effective configuration when developing |
kiview
requested changes
Oct 5, 2022
Apache HTTP client's wire logger produces a large amount of log data, which can include secrets. Therefore recommend turning it off, so that it won't become enabled in case the root logger's level is increased to DEBUG. Fixes testcontainers#4913
Add an example showing how to enable debug logging only for the `org.testcontainers` package. Recommend against enabling debug level on the root logger in order to not be swamped by log data. Fixes testcontainers#4913
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
|
The CircleCI action failed with: :( |
|
thanks for your contribution @edysli ! This is now merged in main branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the recommended logging configuration to reduce the risk of people enabling DEBUG level on the root logger, thereby potentially exposing secrets in HTTP traffic, and being swamped by log data. The example
logback-test.xmlnow disables Apache HTTP client wire logging and shows how to enable debug logging only for Testcontainers.Fixes #4913