Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitlab_ci.md with clarifying note about the docker host port number #6063

Merged
merged 1 commit into from Oct 26, 2022

Conversation

BenManifold
Copy link
Contributor

Clarity around the port number for unencrypted docker host connections, as most gitlab DinD examples recommend 2736 without explaining why.

Clarity around the port number for unencrypted docker host connections, as most gitlab DinD examples recommend 2736 without explaining why.
@BenManifold BenManifold requested a review from a team as a code owner October 25, 2022 15:08
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @BenManifold, great clarification.

@kiview kiview added this to the next milestone Oct 26, 2022
@kiview kiview merged commit 46b6cd9 into testcontainers:main Oct 26, 2022
@lack3r
Copy link

lack3r commented Mar 14, 2023

Not sure if clarification is indeed required here on that comment.
However, the port shown there should be 2375, and not 2735, and thus the added comment is misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants