Use gradle/gradle-build-action
#6121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those are the enefits we can get from the action and our current usage: * Efficient cache * Summary report * Capture of build scan links
github-actions
bot
added
the
github_actions
|
See summary |
kiview
approved these changes
Nov 4, 2022
| - name: Setup Gradle Build Action | ||
| uses: gradle/gradle-build-action@v2 | ||
| with: | ||
| gradle-home-cache-cleanup: true |
There was a problem hiding this comment.
I had to look up the effect of it because I think the name is confusing but it looks like a good idea. I wonder why it is not a default?
There was a problem hiding this comment.
it is experimental but what can go wrong? 🤷🏽♂️
Comment on lines
+26
to
31
| - name: Setup Gradle Build Action | ||
| uses: gradle/gradle-build-action@v2 | ||
|
|
||
| - name: Run Gradle Build | ||
| run: ./gradlew build --scan --no-daemon -i -x test | ||
|
|
There was a problem hiding this comment.
We can also switch to using the gradle-build-action for execution, but it probably changes nothing.
https://github.com/gradle/gradle-build-action#gradle-execution
There was a problem hiding this comment.
that's useful when testing with different gradle versions. In our case would not help that much given we use gradle wrapper
|
The summary report is a great feature and it makes the build scans very accessible 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are the benefits we can get from the action and our current usage: