Add JavaDoc to Spock's Testcontainers annotation #6802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddumelendez
changed the title
|
@rnorth @bsideup @eddumelendez Is there anything else I could do to get this merged? Thanks! |
modules/spock/src/main/groovy/org/testcontainers/spock/Testcontainers.groovy
Outdated
Show resolved
Hide resolved
eddumelendez
approved these changes
Jul 19, 2023
|
Thanks @winne42 ! and sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Testcontainersannotation in the Spock module did not feature any JavaDoc so developers had to guess or read the source code to know what's happening behind the scenes. As a first suggestion I adapted the comment from JUnit'sTestcontainersannotation to Spock/Groovy. I did not copy the warningas I do not know whether the same applies to the Spock extension.