Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SelinuxContext.SHARED by default #7187

Merged
merged 10 commits into from Jun 20, 2023
Merged

Use SelinuxContext.SHARED by default #7187

merged 10 commits into from Jun 20, 2023

Conversation

jeroen-vd-nl
Copy link
Contributor

@jeroen-vd-nl jeroen-vd-nl commented Jun 12, 2023 •
edited

Followup on #6294

  • PR review done
  • Updated branch to latest testcontainers-java

Commits in total:

  • Use shared selinux context for filesystem binds (6294)
  • Update condition (6294)
  • Fix test (6294)
  • Fix format (6294)
  • Review feedback: only needs to mount on READ_WRITE access (new)
  • Update branch (new)

monosoul and others added 9 commits December 6, 2022 22:11
@monosoul
Use shared selinux context for filesystem binds
eb6a1d0 
On systems with SElinux enforcing trying to bind a filesystem path without a context will result in an error. Using shared context by default will make `withFileSystemBind(String hostPath, String containerPath)` method work for all systems. On Windows, Mac OS and Linux systems without SElinux it will have no effect. On systems with SElinux enforcing it will make the path accessible to the container.

Signed-off-by: monosoul <Kloz.Klaud@gmail.com>
@monosoul
Merge branch 'main' into patch-2
0ff9de1
@monosoul
Merge branch 'main' into patch-2
9e21007
@monosoul
Merge branch 'main' into patch-2
66e47b9
@monosoul
Merge branch 'main' into patch-2
04f3ccc
@eddumelendez
Update condition
1c17297
@eddumelendez
Fix test
caf655d
@eddumelendez
Fix format
c49d830
Review feedback: only needs to mount on READ_WRITE access
53b3e34
@jeroen-vd-nl jeroen-vd-nl requested a review from a team as a code owner June 12, 2023 13:31
@jeroen-vd-nl
Copy link
Contributor Author

Update from our side: we can achieve the same result by using the local compose. Still this might be an addition to the code base, but for us the added value has vanished. Maybe for @monosul it still adds value.

@eddumelendez eddumelendez mentioned this pull request Jun 20, 2023
Closed
@eddumelendez eddumelendez added this to the next milestone Jun 20, 2023
@eddumelendez eddumelendez changed the title selinux PR review update Use SelinuxContext.SHARED by default Jun 20, 2023
@eddumelendez eddumelendez merged commit 9220816 into testcontainers:main Jun 20, 2023
85 checks passed
@eddumelendez
Copy link
Member

Thanks @jeroen-vd-nl !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeroen-vd-nl @eddumelendez @monosoul