Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locations set to None in sitemap #7232

Merged
merged 1 commit into from Jun 20, 2023

Conversation

leocross
Copy link
Contributor

Fix a bug with the documentation generating a sitemap with <loc>None</loc> seamingly caused by not having site_url set in the mkdocs config.

e.g.

<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
  <url>
    <loc>None</loc>
    <lastmod>2023-06-15</lastmod>
    <changefreq>daily</changefreq>
  </url>
  ...
</urlset>

@leocross leocross requested a review from a team as a code owner June 20, 2023 17:31
@eddumelendez eddumelendez merged commit c82049b into testcontainers:main Jun 20, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants