Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MSSQL's default username #7238

Merged
merged 1 commit into from Jul 4, 2023
Merged

Fix MSSQL's default username #7238

merged 1 commit into from Jul 4, 2023

Conversation

Eng-Fouad
Copy link
Contributor

Fixes #7237

If MSSQL_COLLATION is set to a collation with case-sensetive (_CS not _CI), the username SA will fail to login to DB, as sa is the correct username.

@eddumelendez
Copy link
Member

eddumelendez commented Jul 4, 2023 •
edited

According to the docs, the username is sa. Also, the default collation is SQL_Latin1_General_CP1_CI_AS which is case insensitive, performing SELECT SERVERPROPERTY('COLLATION').

@eddumelendez eddumelendez added this to the next milestone Jul 4, 2023
@eddumelendez eddumelendez merged commit a00d048 into testcontainers:main Jul 4, 2023
85 checks passed
@Eng-Fouad Eng-Fouad deleted the mssql-username-fix branch July 4, 2023 21:49
@eddumelendez
Copy link
Member

Thanks for your contribution, @Eng-Fouad !

@eddumelendez eddumelendez mentioned this pull request Aug 29, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddumelendez eddumelendez eddumelendez approved these changes

@rnorth rnorth Awaiting requested review from rnorth

@bsideup bsideup Awaiting requested review from bsideup

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
modules/sql-server type/bug
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Default MSSQL username is sa not SA
2 participants
@Eng-Fouad @eddumelendez