Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tabs in Consul module docs #7398

Merged
merged 1 commit into from Aug 6, 2023
Merged

Fix broken tabs in Consul module docs #7398

merged 1 commit into from Aug 6, 2023

Conversation

sh-cho
Copy link
Contributor

@sh-cho sh-cho commented Aug 6, 2023

image
Before (https://java.testcontainers.org/modules/consul/)

image
After (ran it locally)

Also, I noticed that AUTHOR link is not working, since there is no modules/consul/AUTHOR file. Seems like AUTHOR files are not maintained and we can check it via github contributors listing. How do you think about clean it?

@sh-cho sh-cho requested a review from a team as a code owner August 6, 2023 02:10
@eddumelendez eddumelendez added this to the next milestone Aug 6, 2023
@eddumelendez eddumelendez merged commit e11c86f into testcontainers:main Aug 6, 2023
9 checks passed
@eddumelendez
Copy link
Member

Thanks for your contribution, @sh-cho !

@sh-cho sh-cho deleted the sh-cho-patch-1 branch August 6, 2023 02:40
@eddumelendez
Copy link
Member

Also, I noticed that AUTHOR link is not working, since there is no modules/consul/AUTHOR file. Seems like AUTHOR files are not maintained and we can check it via github contributors listing. How do you think about clean it?

Thanks! I noticed it after merging your PR. So, I just push a change for it. Should be fix it in a few minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants