Update Docker requirements page to be more container runtime agnostic #7655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddumelendez
approved these changes
Oct 16, 2023
Comment on lines
+5
to
+6
| To run Testcontainers-based tests, | ||
| you need a Docker-API compatible container runtime, |
There was a problem hiding this comment.
Suggested change
| To run Testcontainers-based tests, | |
| you need a Docker-API compatible container runtime, | |
| To run Testcontainers-based tests, you need a Docker-API compatible container runtime, |
There was a problem hiding this comment.
Oh, the line break here was on purpose, because I use https://sembr.org/ when writing Markdown (generally tends to make diffs easier over time IMO) 😇
Comment on lines
+14
to
+15
| When using those alternatives without Testcontainers Desktop, | ||
| sometimes some manual configuration might be necessary |
There was a problem hiding this comment.
Suggested change
| When using those alternatives without Testcontainers Desktop, | |
| sometimes some manual configuration might be necessary | |
| When using those alternatives without Testcontainers Desktop, sometimes some manual configuration might be necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the "Docker Requirements" page to become more container runtime agnostic.
It also references Testcontainers Cloud as a supported container runtime, as well as mentioning Testcontainers Desktop as a tool that can make using alternative container runtimes easier.
The table of supported Docker-Environment combinations has been removed.
Aligns the messaging with Testcontainers.com Getting Started Page.
Why is it important?
The previous provided a table that was very detailed with regard to certain Docker versions and environments, however, those were not actively tested. In addition, some of the information and workarounds in this table have become outdated and some mentioned technologies (such as Docker Toolbox) are nowadays obsolete and unmaintained.
Mentioning Testcontainers Cloud and Testcontainers Desktop helps with discovery of these products for OSS users.
This change also embraces the fact, that the container runtime has become much more heterogenous in the recent years, while putting the emphasis on Testcontainers integrating against the Docker-API.