Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve strategy to detect the remote docker socket #7727

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

eddumelendez
Copy link
Member

Currently, if DockerClientFactory.instance().getRemoteDockerUnixSocketPath()
is called without resolving the strategy then the remote docker socket
can be invalid, for example, using Docker Desktop for Mac with unchecked
Allow the default Docker socket to be used option.

Fixes #7678

Currently, if `DockerClientFactory.instance().getRemoteDockerUnixSocketPath()`
is called without resolving the strategy then the remote docker socket
can be invalid, for example, using Docker Desktop for Mac with unchecked
`Allow the default Docker socket to be used` option.

Fixes #7678
@eddumelendez eddumelendez requested a review from a team as a code owner October 27, 2023 19:15
@eddumelendez eddumelendez added this to the next milestone Oct 27, 2023
@eddumelendez eddumelendez merged commit 2597da2 into main Oct 27, 2023
87 checks passed
@eddumelendez eddumelendez deleted the gh-7678 branch October 27, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: LocalStack doesn't start if Allow the default Docker socket to be used is unchecked
1 participant