Improve test coverage of container runtime strategies #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cristianrgreco
added
maintenance
cristianrgreco
changed the title
thenglong
reviewed
Aug 14, 2023
| getName(): string { | ||
| return "NpipeSocketStrategy"; | ||
| } | ||
|
|
||
| async getResult(): Promise<ContainerRuntimeClientStrategyResult | undefined> { | ||
| if (process.platform !== "win32") { | ||
| if (this.env.platform !== "win32") { |
There was a problem hiding this comment.
@cristianrgreco May I ask why this changed from process.platform to this.env.platform since the platform value is in the process object itself and not in the process.env. I believe this cause testcontainers to never find runtime strategy on docker windows unless we set the platform env manually.
There was a problem hiding this comment.
Thanks for this @thenglong, you are correct it's an issue. I will release a patch shortly..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.