Add support for targeting a build stage when building a Docker image #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/testcontainers/src/generic-container/generic-container-builder.ts
Outdated
Show resolved
Hide resolved
src/testcontainers/src/generic-container/generic-container.test.ts
Outdated
Show resolved
Hide resolved
src/testcontainers/src/generic-container/generic-container.test.ts
Outdated
Show resolved
Hide resolved
cristianrgreco
added
enhancement
|
Thanks for the PR, much appreciated! Just a few nitpicks. Please also update the docs to let people know this is possible |
cristianrgreco
changed the title
ClaytonNorthey92
force-pushed
the
target-stage
branch
from
7f636fe
to
4ab3748
Compare
|
hey @cristianrgreco thanks for the feedback, I...
let me know if there is anything else 👍 |
cristianrgreco
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allowing a developer the ability to choose a build stage using the
withTargetmethod, see discussion herefixes 629