Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Localstack module #640

Merged
merged 11 commits into from
Dec 10, 2023
Merged

Add Localstack module #640

merged 11 commits into from
Dec 10, 2023

Conversation

ilopezluna
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Aug 16, 2023 •
edited

✅ Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit cdc1628
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/6574d7188367880009baf0f1
😎 Deploy Preview https://deploy-preview-640--testcontainers-node.netlify.app/modules/localstack
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@djakielski
Copy link
Contributor

Hey @ilopezluna, can I support you to make progress?

@ilopezluna ilopezluna changed the title Add localstack support, still work in progress Add localstack support Sep 13, 2023
@ilopezluna ilopezluna marked this pull request as ready for review September 13, 2023 16:06
@ilopezluna
Copy link
Contributor Author

Hey @ilopezluna, can I support you to make progress?

Thanks for offering your help 🙏
We have added a basic implementation following the java implementation

Given that we are not NodeJS experts any suggestion/comment/feedback would be appreciated

@cristianrgreco cristianrgreco added enhancement New feature or request minor Backward compatible functionality labels Oct 26, 2023
@cristianrgreco cristianrgreco changed the title Add localstack support Add Localstack module Dec 9, 2023
@cristianrgreco cristianrgreco merged commit 8c5a9af into testcontainers:main Dec 10, 2023
82 of 83 checks passed
This was referenced Jan 21, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request minor Backward compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ilopezluna @djakielski @cristianrgreco