Allow to start containers with raw image IDs #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker supports starting containers with bare image IDs: ``` docker run aa285b773a2c042056883845aea893a743d358a5d40f61734fa228fde93dae6f ``` However, if a tag or digest is added to the ID, Docker will refuse it: ``` docker run aa285b773a2c042056883845aea893a743d358a5d40f61734fa228fde93dae6f:latest Unable to find image 'aa285b773a2c042056883845aea893a743d358a5d40f61734fa228fde93dae6f:latest' locally docker: Error response from daemon: invalid repository name (aa285b773a2c042056883845aea893a743d358a5d40f61734fa228fde93dae6f), cannot specify 64-byte hexadecimal strings. See 'docker run --help'. ``` We adjust the string conversion of ImageName for this specific case to allow starting containers with bare image IDs. More context: testcontainers/testcontainers-java#7707
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -96,5 +116,13 @@ describe("ContainerImage", () => { | |||
| expect(imageName.image).toBe("image"); | |||
| expect(imageName.tag).toBe("sha256:1234abcd1234abcd1234abcd1234abcd"); | |||
| }); | |||
|
|
|||
| it("should work with image being an image ID", () => { | |||
There was a problem hiding this comment.
Similarly to should keep other tags (not latest) on image IDs, do we need a fromString test where the input has a non-latest tag (aa285b773a2c042056883845aea893a743d358a5d40f61734fa228fde93dae6f:1)?
There was a problem hiding this comment.
Yes, that's probably a good idea. I've added a commit with a test (and also added the docker error message to the text explaining that it won't accept the reference).
cristianrgreco
added
enhancement
cristianrgreco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker supports starting containers with bare image IDs:
However, if a tag or digest is added to the ID, Docker will refuse it:
We adjust the string conversion of ImageName for this specific case to allow starting containers with bare image IDs.
More context:
testcontainers/testcontainers-java#7707