Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire Node 16 (End-of-life) from CI #675

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Retire Node 16 (End-of-life) from CI #675

merged 1 commit into from
Nov 16, 2023

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Nov 15, 2023

Context

Node 16 is End-of-life since September 11th, 2023 (see EOL statement).

schedule
Source: https://nodejs.org/en/about/previous-releases#release-schedule

Based on the diagram above, the only LTS versions are Node 18 and Node 20.

Changes description

  • Remove Node 16.x from the GitHub actions CI's test matrix.

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 5e375c7
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/6554fb6fba1b9200085668de
😎 Deploy Preview https://deploy-preview-675--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I have one question: Is it convenient to add Node 21 to the matrix?

@LNSD
Copy link
Contributor Author

LNSD commented Nov 16, 2023

LGTM!

I have one question: Is it convenient to add Node 21 to the matrix?

Typically, projects test only against LTS versions. Node 21 has a "short lifespan" (temptatively, EOL April 2024), for this reason most of the developers avoid using this intermediate versions in production.

So, IMHO, I wouldn't add it, given that Node 22 (LTS) will be out in few months.

@mdelapenya mdelapenya added the maintenance Improvements that do not change functionality label Nov 16, 2023
@mdelapenya mdelapenya merged commit ec59ed8 into testcontainers:main Nov 16, 2023
75 checks passed
@javierlopezdeancos
Copy link
Contributor

I have a doubt here, we should point our local dev stack to node 18x at least? we couldn't find unexpected catches in ci if we don't do this?

@LNSD LNSD deleted the ci-retire-node16-eol branch November 22, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Improvements that do not change functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants