Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI's podman apt-get repo url #676

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Fix CI's podman apt-get repo url #676

merged 1 commit into from
Nov 15, 2023

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Nov 15, 2023

This PR fixes the CI issue related to the podman package installation step.

Context

The CI test job has consistently failed with a 404 error in the Podman setup step.

[...]
Ign:35 https://download.opensuse.org/repositories/devel:kubic:libcontainers:unstable/xUbuntu_22.04  InRelease
Err:36 https://download.opensuse.org/repositories/devel:kubic:libcontainers:unstable/xUbuntu_22.04  Release
  Redirection from https to 'http://download.opensuse.org/repositories/devel:kubic:libcontainers:/unstable/xUbuntu_22.04/Release' is forbidden [IP: 195.135.223.226 443]
Reading package lists...
E: The repository 'https://download.opensuse.org/repositories/devel:kubic:libcontainers:unstable/xUbuntu_22.04  Release' does not have a Release file.
Error: Process completed with exit code 100.

Issuing a GET request to that endpoint reveals that the path has changed (and the podman documentation has not been updated accordingly).

curl -fsSL -kv https://download.opensuse.org/repositories/devel:kubic:libcontainers:unstable/xUbuntu_22.04/Release  

Multiple redirections (301 Moved permanently) happen before the final URL is queried:

[...]
* Ignoring the response-body
* Connection #1 to host download.opensuse.org left intact
* Issue another request to this URL: 'http://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/unstable/xUbuntu_22.04/Release'
* Found bundle for host: 0x5589f0eef300 [serially]
* Can not multiplex, even if we wanted to
* Re-using existing connection with host download.opensuse.org
> GET /repositories/devel:/kubic:/libcontainers:/unstable/xUbuntu_22.04/Release HTTP/1.1
> Host: download.opensuse.org
> User-Agent: curl/8.4.0
> Accept: */*
> 
< HTTP/1.1 200 OK
< date: Wed, 15 Nov 2023 15:49:46 GMT
< server: Mojolicious (Perl)
< cache-control: public, max-age=101
< content-disposition: inline;filename="Release"
< content-length: 732
< content-type: application/x-download;name="Release"
< 
[...]

So, the new URL should contain / after the ::

http://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/unstable/xUbuntu_22.04/Release

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 54f5d32
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/6554e979b301100008c848c7
😎 Deploy Preview https://deploy-preview-676--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LNSD
Copy link
Contributor Author

LNSD commented Nov 15, 2023

I can confirm the issue has been solved with this fix: https://github.com/LNSD/testcontainers-node/pull/3

image

Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge once the GHA pipeline finished, thanks for taking care of this 🙌

@kiview kiview merged commit 96791f0 into testcontainers:main Nov 15, 2023
35 of 109 checks passed
@kiview
Copy link
Member

kiview commented Nov 15, 2023

Merged, since the failing tests were unrelated to this change, thanks again for looking into this @LNSD 👍

@LNSD LNSD deleted the fix-ci-podman branch November 15, 2023 17:06
@LNSD
Copy link
Contributor Author

LNSD commented Nov 15, 2023

Merged, since the failing tests were unrelated to this change, thanks again for looking into this @LNSD 👍

Nice! Happy to help 💪🏼 😁

@mdelapenya mdelapenya added the maintenance Improvements that do not change functionality label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Improvements that do not change functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants