Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch docker compose defaults from v1 to v2 #681

Conversation

danielglazer
Copy link
Contributor

@danielglazer danielglazer commented Nov 26, 2023

Initial work to fix the issue mentioned here.
Since V1 is deprecated, testcontainers should probably default to V2. could probably override the defaults if we pass it through the process env but not sure if its the right way.
couldn't find related tests that failed because of this change or documentation related change needed.. @cristianrgreco can you help with the review / guide me on further changes?

Copy link

netlify bot commented Nov 26, 2023

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 0f9137b
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/6563a69e3c4465000808e998
😎 Deploy Preview https://deploy-preview-681--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cristianrgreco cristianrgreco added enhancement New feature or request minor Backward compatible functionality labels Nov 27, 2023
@cristianrgreco
Copy link
Collaborator

cristianrgreco commented Nov 27, 2023

Thanks for raising the PR @danielglazer


could probably override the defaults if we pass it through the process env but not sure if its the right way.

Agreed I don't think it's necessary for now

couldn't find related tests that failed because of this change or documentation related change needed..

Indeed we don't test the docker-compose version because it'd be a pain to need both versions installed for tests to pass. The GHA runners have both versions of compose installed. I've also checked locally and it's working as expected.

@cristianrgreco can you help with the review / guide me on further changes?

LGTM, I'm just thinking whether or not this warrants a major change. After that I'll let you know once it's released

@daniel-glazer
Copy link

wasn't able to run all the tests locally by myself.. @cristianrgreco thanks for your quick response!

@cristianrgreco cristianrgreco changed the title switch docker compose defaults from v1 to v2 Switch docker compose defaults from v1 to v2 Nov 27, 2023
@cristianrgreco cristianrgreco merged commit 9941583 into testcontainers:main Nov 27, 2023
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor Backward compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default to compose v2
3 participants