Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom image log line #714

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Fix custom image log line #714

merged 2 commits into from
Feb 29, 2024

Conversation

omerlh
Copy link
Contributor

@omerlh omerlh commented Feb 15, 2024

A small fix for this log message:

Building Dockerfile "<>" as image "[object Object]"...

@netlify Netlify
Copy link

netlify bot commented Feb 15, 2024 •
edited

✅ Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 42d46ba
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/65d304c029a47f00081fef54
😎 Deploy Preview https://deploy-preview-714--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cristianrgreco
Copy link
Collaborator

cristianrgreco commented Feb 16, 2024 •
edited

Thanks @omerlh for raising the PR.
ImageName is an object, it'd be better to log imageName.string instead of JSON.stringifying all of it

@cristianrgreco cristianrgreco added maintenance Improvements that do not change functionality patch Backward compatible bug fix labels Feb 16, 2024
@omerlh
Copy link
Contributor Author

omerlh commented Feb 19, 2024

Sure, fixed!

@cristianrgreco cristianrgreco changed the title fix: use json stringify to fix log message Fix custom image log line Feb 29, 2024
@cristianrgreco cristianrgreco merged commit c514be0 into testcontainers:main Feb 29, 2024
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance Improvements that do not change functionality patch Backward compatible bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@omerlh @cristianrgreco