Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node 20 pipeline #728

Conversation

javierlopezdeancos
Copy link
Contributor

@javierlopezdeancos javierlopezdeancos commented Mar 14, 2024

Install Node js dependency action should install the right Node js version per action description

We can see it in each job that execute test with different Node js versions
imagen

I think that there is an error in the job github template, fixing it we have the expected behavior, installing the right node version
imagen

Close #727

@javierlopezdeancos javierlopezdeancos added the bug Something isn't working label Mar 14, 2024
@javierlopezdeancos javierlopezdeancos self-assigned this Mar 14, 2024
Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit c4ee7cf
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/66068295a4b7860008cbeedf
😎 Deploy Preview https://deploy-preview-728--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@javierlopezdeancos javierlopezdeancos changed the title 727 Install node dependencies action are not taking right node js version Install node dependencies action are not taking right node js version Mar 14, 2024
@javierlopezdeancos javierlopezdeancos added maintenance Improvements that do not change functionality and removed bug Something isn't working labels Mar 14, 2024
Copy link
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! LGTM

Copy link
Collaborator

@cristianrgreco cristianrgreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @javierlopezdeancos, will merge when the build passes

@javierlopezdeancos
Copy link
Contributor Author

Hi @cristianrgreco any ideas about why this job is failing in the Couchbase module? https://github.com/testcontainers/testcontainers-node/actions/runs/8284679078/job/22698328589?pr=728
Something relate tio this change to Node 20.x executions or is something that was appearing previously

@cristianrgreco
Copy link
Collaborator

I've looked into the test failures, seems it's specific to node 20

@javierlopezdeancos
Copy link
Contributor Author

I found that tc-java have the same issue
https://www.couchbase.com/forums/t/test-container-error-with-image-couchbase-enterprise-7-1-4/36200
There are an open issue to resolve it but, is not clear the approach to fix it
testcontainers/testcontainers-java#7049

@cristianrgreco cristianrgreco changed the title Install node dependencies action are not taking right node js version Fix node 20 pipeline Mar 29, 2024
@cristianrgreco cristianrgreco merged commit 9f11d73 into testcontainers:main Mar 29, 2024
112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Improvements that do not change functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install node dependencies action are not taking right node js version
3 participants