Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GCloud module #733

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Add GCloud module #733

merged 2 commits into from
Mar 22, 2024

Conversation

anietieasuquo
Copy link
Contributor

  • Added Firestore emulator container module and docs

@netlify Netlify
Copy link

netlify bot commented Mar 20, 2024 •
edited

✅ Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit e9eb978
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/65fd8a03d9c2b7000827f2bb
😎 Deploy Preview https://deploy-preview-733--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cristianrgreco
Copy link
Collaborator

Looks like some tests are failing

Cannot find module '@google-cloud/firestore/build/src/path' from '../../../node_modules/firebase-admin/lib/firestore/index.js'

@anietieasuquo
Copy link
Contributor Author

Looks like some tests are failing

Cannot find module '@google-cloud/firestore/build/src/path' from '../../../node_modules/firebase-admin/lib/firestore/index.js'

Yeah, I was able to reproduce it locally by running the ci build steps. Fixed now.

@cristianrgreco cristianrgreco changed the title Added Firestore emulator container module and docs Add Firestore emulator module Mar 22, 2024
@cristianrgreco cristianrgreco changed the title Add Firestore emulator module Add GCloud module Mar 22, 2024
@cristianrgreco cristianrgreco merged commit 0488293 into testcontainers:main Mar 22, 2024
112 checks passed
@eddumelendez eddumelendez mentioned this pull request Mar 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddumelendez eddumelendez eddumelendez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anietieasuquo @cristianrgreco @eddumelendez