Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Weaviate module #736

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Add Weaviate module #736

merged 1 commit into from
Mar 29, 2024

Conversation

antas-marcin
Copy link
Contributor

This PR adds a Weaviate module.

@netlify Netlify
Copy link

netlify bot commented Mar 22, 2024 •
edited

✅ Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 5857760
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/65ffe9b89ce3290008525f56
😎 Deploy Preview https://deploy-preview-736--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antas-marcin antas-marcin force-pushed the weaviate-module branch 2 times, most recently from ec31708 to 389ff8a Compare March 22, 2024 16:47
eddumelendez
eddumelendez reviewed Mar 22, 2024
View reviewed changes
Copy link
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Just leave some questions in order to understand better about the settings and if those should be applied to java and go as well.

packages/modules/weaviate/src/weaviate-container.ts Outdated Show resolved Hide resolved
@antas-marcin antas-marcin force-pushed the weaviate-module branch 5 times, most recently from 143adcc to e784654 Compare March 22, 2024 17:12
@cristianrgreco cristianrgreco added enhancement New feature or request minor Backward compatible functionality labels Mar 22, 2024
@cristianrgreco
Copy link
Collaborator

Thanks for the contribution @antas-marcin. Looks like the dependencies aren't being included in the package-lock file

@antas-marcin
Copy link
Contributor Author

Let me take a look at those errors

@antas-marcin antas-marcin changed the title Add Weaviate module feat: Add Weaviate module Mar 22, 2024
@antas-marcin antas-marcin force-pushed the weaviate-module branch 2 times, most recently from e895a78 to b041790 Compare March 23, 2024 08:59
@antas-marcin
Copy link
Contributor Author

I have pushed updated package-lock.json should be fine now

@antas-marcin antas-marcin force-pushed the weaviate-module branch 4 times, most recently from ca96249 to f97daa9 Compare March 23, 2024 22:26
@cristianrgreco cristianrgreco changed the title feat: Add Weaviate module Add Weaviate module Mar 29, 2024
@cristianrgreco cristianrgreco merged commit 155f8fa into testcontainers:main Mar 29, 2024
118 checks passed
@antas-marcin antas-marcin deleted the weaviate-module branch March 29, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierlopezdeancos javierlopezdeancos javierlopezdeancos approved these changes

@eddumelendez eddumelendez eddumelendez approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request minor Backward compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@antas-marcin @cristianrgreco @javierlopezdeancos @eddumelendez