Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error installing dependencies in Node 20x #742

Conversation

javierlopezdeancos
Copy link
Contributor

Fix error installing dependencies in Node 20x

Fix error that appears in a fresh installation in main branch with Node 20.x LTS versions.

What is doing this PR

Update the couchbase module dependency with couchbase to resolve transitional dependencies' installation problems in a fresh clone main version of the project to Node 20.x

testcontainers-node git:(main) node --version
v20.12.0
\u279c  testcontainers-node git:(main) npm i
npm WARN deprecated readdir-scoped-modules@1.1.0: This functionality has been moved to @npmcli/fs
npm WARN deprecated debuglog@1.0.1: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm WARN deprecated @types/redis@4.0.11: This is a stub types definition. redis provides its own type definitions, so you do not need this installed.
npm WARN deprecated @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs
npm WARN deprecated array.prototype.group@1.1.2: This proposal has been altered; please use https://npmjs.com/object.groupby instead!
npm ERR! code 1
npm ERR! path /home/javierlopezdeancos/Code/testcontainers/testcontainers-node/node_modules/couchbase
npm ERR! command failed
npm ERR! command sh -c prebuild-install || node-gyp rebuild
npm ERR! prebuild-install warn install No prebuilt binaries found (target=20.12.0 runtime=node arch=arm64 libc= platform=linux)
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using node-gyp@9.4.1
npm ERR! gyp info using node@20.12.0 | linux | arm64
npm ERR! gyp info find Python using Python version 3.10.12 found at "/usr/bin/python3"
npm ERR! gyp info spawn /usr/bin/python3
npm ERR! gyp info spawn args [
npm ERR! gyp info spawn args   '/home/javierlopezdeancos/Code/testcontainers/testcontainers-node/node_modules/node-gyp/gyp/gyp_main.py',
npm ERR! gyp info spawn args   'binding.gyp',
npm ERR! gyp info spawn args   '-f',
npm ERR! gyp info spawn args   'make',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/home/javierlopezdeancos/Code/testcontainers/testcontainers-node/node_modules/couchbase/build/config.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/home/javierlopezdeancos/Code/testcontainers/testcontainers-node/node_modules/node-gyp/addon.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/home/javierlopezdeancos/.cache/node-gyp/20.12.0/include/node/common.gypi',
npm ERR! gyp info spawn args   '-Dlibrary=shared_library',
npm ERR! gyp info spawn args   '-Dvisibility=default',
npm ERR! gyp info spawn args   '-Dnode_root_dir=/home/javierlopezdeancos/.cache/node-gyp/20.12.0',
npm ERR! gyp info spawn args   '-Dnode_gyp_dir=/home/javierlopezdeancos/Code/testcontainers/testcontainers-node/node_modules/node-gyp',
npm ERR! gyp info spawn args   '-Dnode_lib_file=/home/javierlopezdeancos/.cache/node-gyp/20.12.0/<(target_arch)/node.lib',
npm ERR! gyp info spawn args   '-Dmodule_root_dir=/home/javierlopezdeancos/Code/testcontainers/testcontainers-node/node_modules/couchbase',
npm ERR! gyp info spawn args   '-Dnode_engine=v
npm ERR! gyp info spawn args   '--depth=.',
npm ERR! gyp info spawn args   '--no-parallel',
npm ERR! gyp info spawn args   '--generator-output',
npm ERR! gyp info spawn args   'build',
npm ERR! gyp info spawn args   '-Goutput_dir=.'
npm ERR! gyp info spawn args ]
npm ERR! gyp ERR! build error 
npm ERR! gyp ERR! stack Error: not found: make
npm ERR! gyp ERR! stack     at getNotFoundError (/home/javierlopezdeancos/Code/testcontainers/testcontainers-node/node_modules/which/which.js:10:17)
npm ERR! gyp ERR! stack     at /home/javierlopezdeancos/Code/testcontainers/testcontainers-node/node_modules/which/which.js:57:18
npm ERR! gyp ERR! stack     at new Promise (<anonymous>)
npm ERR! gyp ERR! stack     at step (/home/javierlopezdeancos/Code/testcontainers/testcontainers-node/node_modules/which/which.js:54:21)
npm ERR! gyp ERR! stack     at /home/javierlopezdeancos/Code/testcontainers/testcontainers-node/node_modules/which/which.js:71:22
npm ERR! gyp ERR! stack     at new Promise (<anonymous>)
npm ERR! gyp ERR! stack     at subStep (/home/javierlopezdeancos/Code/testcontainers/testcontainers-node/node_modules/which/which.js:69:33)
npm ERR! gyp ERR! stack     at /home/javierlopezdeancos/Code/testcontainers/testcontainers-node/node_modules/which/which.js:80:22
npm ERR! gyp ERR! stack     at /home/javierlopezdeancos/Code/testcontainers/testcontainers-node/node_modules/isexe/index.js:42:5
npm ERR! gyp ERR! stack     at /home/javierlopezdeancos/Code/testcontainers/testcontainers-node/node_modules/isexe/mode.js:8:5
npm ERR! gyp ERR! System Linux 5.15.0-101-generic
npm ERR! gyp ERR! command "/home/javierlopezdeancos/.nvm/versions/node/v20.12.0/bin/node" "/home/javierlopezdeancos/Code/testcontainers/testcontainers-node/node_modules/.bin/node-gyp" "rebuild"
npm ERR! gyp ERR! cwd /home/javierlopezdeancos/Code/testcontainers/testcontainers-node/node_modules/couchbase
npm ERR! gyp ERR! node -v v20.12.0
npm ERR! gyp ERR! node-gyp -v v9.4.1
npm ERR! gyp ERR! not ok

npm ERR! A complete log of this run can be found in: /home/javierlopezdeancos/.npm/_logs/2024-04-01T08_33_53_220Z-debug-0.log

Close #741

@javierlopezdeancos javierlopezdeancos self-assigned this Apr 1, 2024
@javierlopezdeancos javierlopezdeancos added bug Something isn't working dependencies Pull requests that update a dependency file labels Apr 1, 2024
Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 5eebde2
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/660a800af754f8000865b723
😎 Deploy Preview https://deploy-preview-742--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cristianrgreco cristianrgreco added the patch Backward compatible bug fix label Apr 1, 2024
@cristianrgreco cristianrgreco removed the dependencies Pull requests that update a dependency file label Apr 1, 2024
@cristianrgreco cristianrgreco merged commit 23f7c0a into testcontainers:main Apr 1, 2024
112 of 113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Backward compatible bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error installing dependencies in Node 20.x
3 participants