Add Redpanda module #743
Add Redpanda module #743
Conversation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cristianrgreco
added
enhancement
|
Thanks for the contribution @stfnzl. Could you have a look at the failing tests? |
|
@cristianrgreco tests are failing on podman, which i'm not really familiar with. I installed podman and ran the test locally and they pass though... |
There was a problem hiding this comment.
Thanks for the contribution, @stfnzl ! I've left a few comments.
| public getAdminAddress(): string { | ||
| return `http://${this.getHost()}:${this.getMappedPort(REDPANDA_ADMIN_PORT)}`; | ||
| } | ||
|
|
||
| public getRestProxyAddress(): string { | ||
| return `http://${this.getHost()}:${this.getMappedPort(REST_PROXY_PORT)}`; | ||
| } |
There was a problem hiding this comment.
Can we please add some tests for those?
| const client = await getContainerRuntimeClient(); | ||
| const container = client.container.getById(inspectResult.name.substring(1)); | ||
| const renderedRedpandaFile = path.join(os.tmpdir(), `redpanda-${container.id}.yaml`); | ||
| fs.writeFileSync( | ||
| renderedRedpandaFile, | ||
| this.renderRedpandaFile(client.info.containerRuntime.host, inspectResult.ports[REDPANDA_PORT][0].hostPort) | ||
| ); | ||
| const tar = archiver("tar"); | ||
| tar.file(renderedRedpandaFile, { name: "/etc/redpanda/redpanda.yaml" }); | ||
| tar.finalize(); | ||
| await client.container.putArchive(container, tar, "/"); | ||
| fs.unlinkSync(renderedRedpandaFile); |
There was a problem hiding this comment.
I think this can be replaced by using container.copyContentToContainer. See kafka-container as a reference.
There was a problem hiding this comment.
Yes, I took a deeper look on how kafka was implemented and adapted to use copyContentToContainer
This PR adds a Redpanda module.