Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChromaDB module #746

Merged
merged 6 commits into from
Apr 3, 2024
Merged

Conversation

AlabasterAxe
Copy link
Contributor

@AlabasterAxe AlabasterAxe commented Apr 2, 2024

ChromaDB already has testcontainers for Java and Go: https://testcontainers.com/modules/chroma/ This just adds it for Node as well.

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 6022d56
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/660c1d721edd6500085759d3
😎 Deploy Preview https://deploy-preview-746--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

constructor(startedTestContainer: StartedTestContainer) {
super(startedTestContainer);
this.host = this.startedTestContainer.getHost();
this.port = this.startedTestContainer.getMappedPort(CHROMADB_PORT);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port may change if the container is restarted, I would get the mapped port on demand each time instead of once on construction

Copy link
Collaborator

@cristianrgreco cristianrgreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Could you please also add a page in the docs?

@AlabasterAxe
Copy link
Contributor Author

Thanks for the contribution! Could you please also add a page in the docs?

done! although it doesn't look like the netlify built again so I'm not 100% sure that I got the markdown right for the example.

@javierlopezdeancos
Copy link
Contributor

Thanks for the contribution! Could you please also add a page in the docs?

done! although it doesn't look like the netlify built again so I'm not 100% sure that I got the markdown right for the example.

I just re run the jobs again

@cristianrgreco
Copy link
Collaborator

Thanks for the contribution! Could you please also add a page in the docs?

done! although it doesn't look like the netlify built again so I'm not 100% sure that I got the markdown right for the example.

Thanks, you'll need to add a link in the mkdocs.yml in the project root

@AlabasterAxe
Copy link
Contributor Author

Okay, I've updated the readme to add a section about updating the docs, too in case that's useful :)

@cristianrgreco
Copy link
Collaborator

Okay, I've updated the readme to add a section about updating the docs, too in case that's useful :)

Thanks, though that would be better placed in the CONTRIBUTING.md

@cristianrgreco cristianrgreco added enhancement New feature or request minor Backward compatible functionality labels Apr 2, 2024
@AlabasterAxe
Copy link
Contributor Author

Okay, I've moved the bit about updating the docs into contributing and added a link to contributing.md from the readme

@cristianrgreco cristianrgreco changed the title Add a chromadb node testcontainer Add ChromaDB module Apr 2, 2024
@cristianrgreco cristianrgreco merged commit 1337e9c into testcontainers:main Apr 3, 2024
118 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor Backward compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants