-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix checking Reaper and the SSHd containers when _HUB_IMAGE_NAME_PREFIX
provided
#751
Fix checking Reaper and the SSHd containers when _HUB_IMAGE_NAME_PREFIX
provided
#751
Conversation
…_HUB_IMAGE_NAME_PREFIX is specified
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
As we set the reaper's image name it's not possible to add an autotest for that, unless this value is calculated every time. |
Hey @cristianrgreco, codeql was right. I fixed that regex. |
… consisting of a registry with a slash but without path
Thanks for pushing these fixes @silh. I'll merge and release once the build is passing |
_HUB_IMAGE_NAME_PREFIX
provided
Hey @cristianrgreco, now reading it #752 more thoroughly I am not entirely sure if these fixes would resolve the problem. @AlessioFranceschi are you able to use your ECR images without |
Yes by not using the env but putting the registry url together with the image name it works. Thanks |
Additional fix for the issue #747.
Thanks to @joyrex2001 for pointing to ruyk image name comparison problems.
The changes were tested with specifying
TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX=docker.io
for the test run.