-
Notifications
You must be signed in to change notification settings - Fork 306
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: testcontainers/testcontainers-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: testcontainers-v4.5.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: testcontainers/testcontainers-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: testcontainers-v4.5.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 5 commits
- 7 files changed
- 6 contributors
Commits on May 27, 2024
-
chore: add .gitattributes file for shell scripts (#581)
Just a .gitattributes file to checkout .sh files with LF line ending for people coming from Windows world. --------- Co-authored-by: David Ankin <daveankin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8fe2d6d - Browse repository at this point
Copy the full SHA 8fe2d6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 78b6f0e - Browse repository at this point
Copy the full SHA 78b6f0eView commit details -
fix(keycloak): realm import (#584)
With the option to import keycloak realms, introduced with #565, the[_configure()](https://github.com/testcontainers/testcontainers-python/blob/78b6f0ecb15e8cba687eb4588c5ce19ca32208bc/modules/keycloak/testcontainers/keycloak/__init__.py#L57) method is called twice. Once it is called in the [start()](https://github.com/testcontainers/testcontainers-python/blob/78b6f0ecb15e8cba687eb4588c5ce19ca32208bc/modules/keycloak/testcontainers/keycloak/__init__.py#L83) method of keycloak itself and then it is called a second time in the [start()](https://github.com/testcontainers/testcontainers-python/blob/78b6f0ecb15e8cba687eb4588c5ce19ca32208bc/core/testcontainers/core/container.py#L90) method of DockerContainer. This wasn't an issue so far. But if a realm shall be imported (self.has_realm_import in keycloak is True), then every time the string " --import-realm" is added to the start command in the _configure() method. The keycloak container won't start if "--import-realm" is specified multiple times. This is probably the easiest solution to solve the issue. If wished, I can also work on a more robust solution, e.g. by storing the start command in a list and checking that "--import-realm" is only added once. Co-authored-by: Sebastian Scholz <sebastian.scholz@cemocom.de>
Configuration menu - View commit details
-
Copy full SHA for 111bd09 - Browse repository at this point
Copy the full SHA 111bd09View commit details
Commits on May 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8917772 - Browse repository at this point
Copy the full SHA 8917772View commit details -
chore(main): release testcontainers 4.5.1 (#586)
🤖 I have created a release *beep* *boop* --- ## [4.5.1](testcontainers-v4.5.0...testcontainers-v4.5.1) (2024-05-31) ### Bug Fixes * **k3s:** add configuration parameter for disabling cgroup mount to avoid "unable to apply cgroup configuration" ([#592](#592)) ([8917772](8917772)) * **keycloak:** realm import ([#584](#584)) ([111bd09](111bd09)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a95af7d - Browse repository at this point
Copy the full SHA a95af7dView commit details
There are no files selected for viewing