feat(release): automate release via release-please #429
+103
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 27, 2024
Closed
jankatins
reviewed
Feb 28, 2024
.github/actions/setup-env/action.yml
Outdated
| inputs: | ||
| python-version: | ||
| description: "The python version to install and use" | ||
| default: "3.11" # we default to latest supported |
There was a problem hiding this comment.
... which is python 3.12: https://devguide.python.org/versions/
There was a problem hiding this comment.
Not quite! :)
https://github.com/testcontainers/testcontainers-python/blob/main/pyproject.toml#L58-L59
BUT, this is definitely a no-brainer follow up once we've rebooted! Thanks for reading! ❤️
There was a problem hiding this comment.
Oh fuuu... That should definitely be a <4.0 or even unbounded (I really dislike poetry in that regard, there are a lot of arguments that libraries should never use upper bounds in their own dependency spec).
Fun, we actually use testcontainers-python (or better all the "current" small packages) in a py3.12 project.
Really looking forward to get this rebooted and then a few of the "get rid of dependencies by looking at logs" PRs merged.
There was a problem hiding this comment.
@jankatins in the end it took no effort
a342b60
The project is running off of my and @alexanderankin 's excess energy.
Thanks for showing support, it adds a little extra energy to the mix, makes things easier.
|
We should create a separate issue for aggregating things for 4.1 release -
some things like Redis async and the dependency slimming will have to be
coordinated
…On Wed, Feb 28, 2024, 7:57 AM Jan Katins ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/actions/setup-env/action.yml
<#429 (comment)>
:
> @@ -0,0 +1,20 @@
+name: setup-env
+description: set up the python environment
+
+inputs:
+ python-version:
+ description: "The python version to install and use"
+ default: "3.11" # we default to latest supported
Oh fuuu... That should definitely be a >4.0 or even unbounded (I really
dislike poetry in that regard, there are a lot of arguments that libraries
should never use upper bounds in their own dependency spec).
Fun, we actually use testcontainers-python (or better all the "current"
small packages) in a py3.12 project.
Really looking forward to get this rebooted and then a few of the "get rid
of dependencies by looking at logs" PRs merged.
—
Reply to this email directly, view it on GitHub
<#429 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACECGJBU4KLT4I5HCJALDJDYV5AVBAVCNFSM6AAAAABD4DR6SGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMBWGQ4TEMRTG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: <testcontainers/testcontainers-python/pull/429/review/1906492237@
github.com>
|
Closed
totallyzen
pushed a commit
that referenced
this pull request
Mar 6, 2024
🤖 I have created a release *beep* *boop* --- ## [4.0.0](testcontainers-v3.7.1...testcontainers-v4.0.0) (2024-03-06) ### Release Notes The breaking changes are the ones we were able to easily track. If you spot any new issues between `3.7.1` and `4.0.0`, please do report it and we'll do our best to fix everything. The release is now Some kudos from @totallyzen to folks who helped a great deal in starting things again: - kudos to @alexanderankin for his contribution on #426 - kudos to @jankatins for feedback on various PRs including - kudos to @max-pfeiffer and @bearrito for their contributions as well ### ⚠ BREAKING CHANGES * **compose:** implement compose v2 with improved typing ([#426](#426)) * **core:** add support for `tc.host` and de-prioritise `docker:dind` ([#388](#388)) ### Features * **build:** use poetry and organise modules ([#408](#408)) ([6c69583](6c69583)) * **compose:** allow running specific services in compose ([f61dcda](f61dcda)) * **compose:** implement compose v2 with improved typing ([#426](#426)) ([5356caf](5356caf)) * **core:** add support for `tc.host` and de-prioritise `docker:dind` ([#388](#388)) ([2db8e6d](2db8e6d)) * **redis:** support AsyncRedisContainer ([#442](#442)) ([cc4cb37](cc4cb37)) * **release:** automate release via release-please ([#429](#429)) ([30f859e](30f859e)) ### Bug Fixes * Added URLError to exceptions to wait for in elasticsearch ([0f9ad24](0f9ad24)) * **build:** add `pre-commit` as a dev dependency to simplify local dev and CI ([#438](#438)) ([1223583](1223583)) * **build:** early exit strategy for modules ([#437](#437)) ([7358b49](7358b49)) * changed files breaks on main ([#422](#422)) ([3271357](3271357)) * flaky garbage collection resulting in testing errors ([#423](#423)) ([b535ea2](b535ea2)) * rabbitmq readiness probe ([#375](#375)) ([71cb75b](71cb75b)) * **release:** prove that the release process updates the version ([#444](#444)) ([87b5873](87b5873)) * test linting issue ([427c9b8](427c9b8)) ### Documentation * Sphinx - Add title to each doc page ([#443](#443)) ([750e12a](750e12a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes
release-pleaseas the release automation tool3.12- seems it didn't take much extra effortnotes
3.7.1is the latest on PyPI.github/.release-please-manifest.json-> went with the sha from3.7.1which thenrelease-pleasewill take as "latest live version", also made3.7.1in the manifest