Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add CassandraContainer #476

Merged
merged 3 commits into from
Mar 31, 2024
Merged

fix: Add CassandraContainer #476

merged 3 commits into from
Mar 31, 2024
+162 −1

Conversation

cbornet
Copy link
Contributor

@cbornet cbornet commented Mar 14, 2024

No description provided.

@cbornet cbornet changed the title Add CassandraContainer feat: Add CassandraContainer Mar 15, 2024
cbornet
cbornet commented Mar 18, 2024
View reviewed changes
modules/cassandra/testcontainers/cassandra/__init__.py
self.with_exposed_ports(self.port)

def _connect(self):
wait_for_logs(self, "Startup complete")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the preferred strategy for the readiness probe ?
I have used wait_for_logs here because it doesn't need to depend on the cassandra driver.
But I see that the Java implementation uses the driver and it gives the opportunity to provide an init script.

@cbornet
Add CassandraContainer

Verified

This commit was signed with the committer’s verified signature.
MadVikingGod Aaron Clawson
GPG key ID: 9B219B3C9BBA18F4
Verified
Learn about vigilant mode
8651de9
@alexanderankin
Copy link
Member

alexanderankin commented Mar 20, 2024 •
edited
Loading

there is work on going here #167 (comment) too

@cbornet
Copy link
Contributor Author

cbornet commented Mar 20, 2024

Oh, sorry I missed that ! The PR has been opened for more than 2 years ?!
Feel free to merge any of them. With your latest fruch@2b238a2 they are very similar.
Some differences to note:

  • This one doesn't depend on the cassandra driver. It exposes a contact points tuple instead of a Cluster(). The tuple can be fed directly to a Cluster constructor.
  • This one adds an entry in .github/settings.xml

@alexanderankin alexanderankin added the community-feat feature but its a community module so we wont bump tc core for it label Mar 26, 2024
@alexanderankin
linting

Verified

This commit was signed with the committer’s verified signature.
MadVikingGod Aaron Clawson
GPG key ID: 9B219B3C9BBA18F4
Verified
Learn about vigilant mode
0d5b97a
@alexanderankin
fix doctests

Verified

This commit was signed with the committer’s verified signature.
MadVikingGod Aaron Clawson
GPG key ID: 9B219B3C9BBA18F4
Verified
Learn about vigilant mode
Loading
Loading status checks…
4e4fa41
@alexanderankin alexanderankin force-pushed the cassandra branch 2 times, most recently from dacdbca to 4e4fa41 Compare March 31, 2024 00:07
@alexanderankin alexanderankin changed the title feat: Add CassandraContainer fix: Add CassandraContainer Mar 31, 2024
@alexanderankin alexanderankin merged commit 507e466 into testcontainers:main Mar 31, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request Mar 30, 2024
Merged
alexanderankin pushed a commit that referenced this pull request Apr 1, 2024
@github-actions
chore(main): release testcontainers 4.3.0 (#500)

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Loading
Loading status checks…
f819c7a 
🤖 I have created a release *beep* *boop*
---


##
[4.3.0](testcontainers-v4.2.0...testcontainers-v4.3.0)
(2024-04-01)


### Features

* **client:** Add custom User-Agent in Docker client as
`tc-python/<version>`
([#507](#507))
([dd55082](dd55082))


### Bug Fixes

* Add CassandraContainer
([#476](#476))
([507e466](507e466))
* add chroma container
([#515](#515))
([0729bf4](0729bf4))
* Add Weaviate module
([#492](#492))
([90762e8](90762e8))
* **cassandra:** make cassandra dependency optional/test-only
([#518](#518))
([bddbaeb](bddbaeb))
* **core:** allow setting docker command path for docker compose
([#512](#512))
([63fcd52](63fcd52))
* **google:** add support for Datastore emulator
([#508](#508))
([3d891a5](3d891a5))
* Improved Oracle DB module
([#363](#363))
([6e6d8e3](6e6d8e3))
* inconsistent test runs for community modules
([#497](#497))
([914f1e5](914f1e5))
* **kafka:** Add redpanda testcontainer module
([#441](#441))
([451d278](451d278))
* **kafka:** wait_for_logs in kafka container to reduce lib requirement
([#377](#377))
([909107b](909107b))
* **keycloak:** container should use dedicated API endpoints to
determine container readiness
([#490](#490))
([2e27225](2e27225))
* **nats:** Client-Free(ish) NATS container
([#462](#462))
([302c73d](302c73d))
* **new:** add a new Docker Registry test container
([#389](#389))
([0f554fb](0f554fb))
* pass doctests, s/doctest/doctests/, run them in gha,
s/asyncpg/psycopg/ in doctest, fix keycloak flakiness: wait for first
user
([#505](#505))
([545240d](545240d))
* pass updated keyword args to Publisher/Subscriber client in
google/pubsub
[#161](#161)
([#164](#164))
([8addc11](8addc11))
* Qdrant module
([#463](#463))
([e8876f4](e8876f4))
* remove accidentally added pip in dev dependencies
([#516](#516))
([dee20a7](dee20a7))
* **ryuk:** Enable Ryuk test suite. Ryuk image 0.5.1 -> 0.7.0. Add
RYUK_RECONNECTION_TIMEOUT env variable
([#509](#509))
([472b2c2](472b2c2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@cbornet cbornet deleted the cassandra branch April 2, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community-feat feature but its a community module so we wont bump tc core for it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cbornet @alexanderankin