Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider explicitly tagging images prior to uploading them to docker registry #21

Open
banagale opened this issue Sep 20, 2022 · 0 comments

Comments

@banagale
Copy link

It seems like best practice is to explicitly tag an image using :latest. This is currently missing from the workflow for web and nginx: https://github.com/testdrivenio/django-github-digitalocean/blob/master/.github/workflows/main.yml#L45

Tagging like this is done in other parts of the guide, so perhaps this is just an oversight.

I've seen an SO where someone suspects their images on Github container registry are not getting updated because they are not getting explicitly tagged. I can't say if that's the case or not, but I came across it while trying to diagnose for #20.

Regardless, it would be great if the guide detailed automatically tagging images using the short version of the image's git commit hash.

If helpful, I could craft a PR for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant