Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

testground treats ipfs/go-log info logs as error onces #1476

Open
Bidon15 opened this issue Sep 26, 2022 · 2 comments
Open

testground treats ipfs/go-log info logs as error onces #1476

Bidon15 opened this issue Sep 26, 2022 · 2 comments
Labels
hint/needs-triage Hint: Needs Triage

Comments

@Bidon15
Copy link
Member

Bidon15 commented Sep 26, 2022

Introduction 馃憢

At Celestia, we are utilising ipfs/go-log for our sw. While using testground, we observed that TG treats logs as error messages instead of message or other formats. Q: Is this behaviour a bug or a feature 馃 ?

Environment 馃崣

  • Version of TG: 63a8fce
  • Env: Ubuntu 20 LTS
  • Docker Engine Version: 20.10.14

Steps 馃懀

  1. git clone https://github.com/Bidon15/test-logv2
  2. testground plan import --from . --name test-logv2
  3. testground run single --plan test-logv2 --testcase smallbrain --builder docker:generic --runner local:docker --instances 10 --wait

Expected Results

  • Logs from ipfs/go-log are sorted on the same section as runenv.RecordMessage

Actual Results

We have double of the same logs (other and error)

Sep 26 14:40:38.722833	INFO	3.1806s    MESSAGE << single[005] (53909b) >> I am seq 9 #this one is with runenv.RecordMessage()
Sep 26 14:40:38.722861	INFO	3.1830s      OTHER << single[005] (53909b) >> 2022-09-26T14:40:38.720Z	INFO	test	plan/main.go:34	I am seq 9
Sep 26 14:40:38.722796	INFO	3.1829s      ERROR << single[005] (53909b) >> 2022-09-26T14:40:38.720Z	INFO	test	plan/main.go:34	I am seq 9
@Bidon15
Copy link
Member Author

Bidon15 commented Sep 26, 2022

To mitigate the error displays, I've gone to hot-fix the go-log to pipe to stdout instead of default stderr
ipfs/go-log#136

@laurentsenta
Copy link
Contributor

Thanks for creating this issue @Bidon15,
related issue: #1355

If I recall correctly, the sdk-go outputs raw message AND JSON Payloads, which might explain the duplicate message.

@laurentsenta laurentsenta added the hint/needs-triage Hint: Needs Triage label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hint/needs-triage Hint: Needs Triage
Projects
None yet
Development

No branches or pull requests

2 participants