Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @testing-library/dom #260

Open
zenblender opened this issue Aug 22, 2023 · 1 comment
Open

Update @testing-library/dom #260

zenblender opened this issue Aug 22, 2023 · 1 comment

Comments

@zenblender
Copy link

  • cypress-testing-library version: 9.0.0
  • node version: 19.4.0
  • npm (or yarn) version: 9.2.0

Problem description:

Should this be updated with the latest @testing-library/dom? (Currently 9.3.1)

I’ve noticed incompatibilities with other libraries that use the latest version of @testing-library/dom, such as @testing-library/react and @testing-library/user-event. Having both versions 8 and 9 in a project causes confusion and errors, for example about whether user-event actions need to be wrapped in act.

Suggested solution:

Update cypress-testing-library to use the latest version of @testing-library/dom.

@radoslawgrochowski
Copy link

Bumping.

Because of difference between versions of @testing-library/react and @testing-library/cypress I've got error like you mentioned.

console.error
  Warning: The current testing environment is not configured to support act(...)

I see there is pending PR #262 .

Since it looks like there is no breaking change between versions, I'm working with pnpm.packageExtensions till there is version bump:

"pnpm": {
  "packageExtensions": {
    "@testing-library/cypress@9.0.0": {
      "dependencies": {
        "@testing-library/dom": "^9.0.0"
      }
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants