From 29a17cb5f14b0f30f08a29172e35e55c3e8ba529 Mon Sep 17 00:00:00 2001 From: Sebastian Silbermann Date: Sat, 9 Jul 2022 13:05:12 +0200 Subject: [PATCH] fix: load and error dispatch `Event` instead of `UIEvent` (#1147) --- src/__tests__/events.js | 15 ++++++++++----- src/event-map.js | 8 ++++++-- 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/src/__tests__/events.js b/src/__tests__/events.js index 35b40a70..8f8ea563 100644 --- a/src/__tests__/events.js +++ b/src/__tests__/events.js @@ -71,6 +71,16 @@ const eventTypes = [ events: ['scroll'], elementType: 'div', }, + { + type: '', + events: ['load', 'error'], + elementType: 'img', + }, + { + type: '', + events: ['load', 'error'], + elementType: 'script', + }, { type: 'Wheel', events: ['wheel'], @@ -105,11 +115,6 @@ const eventTypes = [ ], elementType: 'video', }, - { - type: 'Image', - events: ['load', 'error'], - elementType: 'img', - }, { type: 'Animation', events: ['animationStart', 'animationEnd', 'animationIteration'], diff --git a/src/event-map.js b/src/event-map.js index 9a09de73..f638d490 100644 --- a/src/event-map.js +++ b/src/event-map.js @@ -274,9 +274,13 @@ export const eventMap = { EventType: 'Event', defaultInit: {bubbles: false, cancelable: false}, }, - // Image Events + // Events load: { - EventType: 'UIEvent', + // TODO: load events can be UIEvent or Event depending on what generated them + // This is were this abstraction breaks down. + // But the common targets are ,