fix: load and error dispatch Event instead of UIEvent
#1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
force-pushed
the
fix/script-onload
branch
from
8e52670
to
25b044b
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 25b044b:
|
Codecov Report
@@ Coverage Diff @@
## main #1147 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 985 985
Branches 321 325 +4
=========================================
Hits 985 985
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
MatanBobi
approved these changes
Jul 9, 2022
|
🎉 This PR is included in version 8.14.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
fireEvent.load(et. al.) dispatches aEventnow instead ofUIEventAdds a test for #498
Why:
I imagine that the most common targets are
<img />and<script />and neither of these receive load events asUIEvent: https://codesandbox.io/s/react-script-does-not-work-the-way-you-think-it-does-stc66cHow:
Changed event type and added tests for
<script />. Ieft a note that our abstraction doesn't support firing events with different types.Also removed the notion of "Image events" from comments. We refer to DOM interfaces in all other cases. But there is no such thing as
ImageEvent.Checklist:
[ ]Documentation added to thedocs site
[ ]TypeScript definitions updated