Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't assume named exports interop #1154

Merged
merged 1 commit into from Aug 4, 2022

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Aug 4, 2022

What:

Closes #995

Why:

The ecosystem is annoying

How:

Follow advise of error message:

SyntaxError: Named export 'compressToEncodedURIComponent' not found. The requested module 'lz-string' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'lz-string';
const { compressToEncodedURIComponent } = pkg;

Checklist:

  • [ ] Documentation added to the
    docs site
  • [ ] Tests
  • [ ] TypeScript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c3c10fe:

Sandbox Source
react-testing-library-examples Configuration

@eps1lon eps1lon marked this pull request as ready for review August 4, 2022 17:36
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #1154 (c3c10fe) into main (73a5694) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1154   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          989       989           
  Branches       325       322    -3     
=========================================
  Hits           989       989           
Flag Coverage Δ
node-12 100.00% <100.00%> (ø)
node-14 100.00% <100.00%> (ø)
node-16 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/screen.ts 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@eps1lon eps1lon merged commit 4f965e9 into testing-library:main Aug 4, 2022
@eps1lon eps1lon deleted the lz-string-import branch August 4, 2022 20:05
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

🎉 This PR is included in version 8.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some dependencies don't support ES modules
2 participants