Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading advice in waitForElement deprecation warning #588

Merged

Conversation

pelotom
Copy link
Contributor

@pelotom pelotom commented May 27, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 86cc1c3:

Sandbox Source
eloquent-jepsen-41ml5 Configuration

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #588 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #588   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          462       462           
  Branches       114       114           
=========================================
  Hits           462       462           
Impacted Files Coverage Δ
src/wait-for-element.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2165a3...86cc1c3. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit b641e8d into testing-library:master May 27, 2020
@kentcdodds
Copy link
Member

@all-contributors please add @pelotom for code and tests

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @pelotom! 🎉

@kentcdodds
Copy link
Member

🎉 This PR is included in version 7.5.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading deprecation warning when using waitForElement
2 participants