Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more improvements to suggestions #599

Merged
merged 2 commits into from Jun 1, 2020
Merged

Conversation

benmonro
Copy link
Member

@benmonro benmonro commented May 31, 2020

What:

  • Fixed bug that would suggest a query that would yield a different element than the one being verified. Also added additional test for label > title.
  • Fixed bug that would suggest get by role w/ name that had un-escaped regexp that would not yield the element intended.

Why: suggestions should give the same results, just using better queries.

How:

  • use specific || implied roles.
  • escape regexp

Checklist:

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 31, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3950f8b:

Sandbox Source
new-star-53pe1 Configuration

@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #599 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #599   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          536       535    -1     
  Branches       133       134    +1     
=========================================
- Hits           536       535    -1     
Impacted Files Coverage Δ
src/suggestions.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bec190b...3950f8b. Read the comment docs.

@benmonro benmonro changed the title fix: don't suggest query that would result in different element fix: more improvements to suggestions Jun 1, 2020
@kentcdodds kentcdodds merged commit caf76e3 into master Jun 1, 2020
@kentcdodds kentcdodds deleted the bug/more-suggestion-fixes branch June 1, 2020 01:08
@benmonro
Copy link
Member Author

benmonro commented Jun 1, 2020

Thanks for patience & letting me iterate @kentcdodds. 😁 As I build more features into the extension and find issues, I'm fixing as I go.

@kentcdodds
Copy link
Member

🎉 This PR is included in version 7.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants