feat(config): add new eventWrapper config for wrapping fireEvent
#600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended for supporting `act` in React, but should be useful for other frameworks (I think it could help with triggering change detection for angular for example). Ref: testing-library/user-event#188, testing-library/user-event#255, https://github.com/testing-library/user-event/issues/277
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cd4f554:
|
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 535 537 +2
Branches 134 134
=========================================
+ Hits 535 537 +2
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 7.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
4 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: feat(config): add new
eventWrapperconfig for wrapping fireEventWhy: So we don't have to do this nonsense: https://github.com/testing-library/react-testing-library/blob/0afcbea3c3d1ddce218a36d963d39fa83f9a7cf6/src/pure.js#L107-L128
How: Add the config
Checklist:
docs site
DefinitelyTyped
This is intended for supporting
actin React, but should be useful forother frameworks (I think it could help with triggering change detection
for angular for example).
Ref: testing-library/user-event#188,
testing-library/user-event#255,
https://github.com/testing-library/user-event/issues/277