feat: use regex based TextMatch for suggestions #617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
I've adjusted the query suggestions to use regex-based text matchers when possible. This impacts all query methods, except for the
Role
variants. I believeroles
need to be exact.Currently, suggestions like these are made:
With this PR, the same suggestions look like:
Why:
Because I believe that tests shouldn't fail due to a change in capitalization.
For that same reason, we already did this for
name
option inRole
queries:So it only makes sense to do this for other queries as well.
How:
In the
makeSuggestion
function, theTextMatch
is now wrapped in a regex when the query name isn'tRole
. Nothing fancy, justquery !== 'Role'
=>text = new RegExp(text.toLowerCase(), 'i')
Checklist:
docs site
DefinitelyTyped
I've also added
.idea
to.gitignore
. Am I really the only one who's using WebStorm? 馃槺