Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in type definition for suggestions #642

Merged

Conversation

geoffharcourt
Copy link
Contributor

What:
Fixing a type definition typo

Why:

It appears that in 7f8a15e there was a subtle typo where the lower-case
testid was misspelled.

How:
I fixed the typo.

Checklist:

  • Documentation added to the
    docs site N/A
  • Tests N/A
  • Typescript definitions updated N/A
  • Ready to be merged

It appears that in 7f8a15e there was a subtle typo where the lower-case
`testid` was misspelled.
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 66bb6bb:

Sandbox Source
lively-feather-f429w Configuration

@codecov
Copy link

codecov bot commented Jun 14, 2020

Codecov Report

Merging #642 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #642   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          565       565           
  Branches       141       141           
=========================================
  Hits           565       565           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a76dfad...66bb6bb. Read the comment docs.

Copy link
Member

@smeijer smeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@smeijer smeijer merged commit d5e17bd into testing-library:master Jun 14, 2020
@geoffharcourt geoffharcourt deleted the gh-fix-suggestions-type-typo branch June 14, 2020 19:44
@kentcdodds
Copy link
Member

🎉 This PR is included in version 7.14.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@marcosvega91
Copy link
Member

😣 my fault

@kentcdodds
Copy link
Member

No worries! Thank you 😁

@kentcdodds
Copy link
Member

@all-contributors please add @geoffharcourt for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @geoffharcourt! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants