Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed bug in toHaveAttribute('style') check #81

Merged
merged 2 commits into from Sep 10, 2020

Conversation

benmonro
Copy link
Member

@benmonro benmonro commented Sep 10, 2020

What: Fixes issue with toHaveAttribute check.

Why: so unrelated code doesn't trigger error

How: fixed bug in selector for toHaveAttribute

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #81 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #81   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          184       184           
  Branches        21        21           
=========================================
  Hits           184       184           
Impacted Files Coverage Δ
src/rules/prefer-to-have-style.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d639db4...ec66795. Read the comment docs.

@benmonro benmonro merged commit 167137a into master Sep 10, 2020
@benmonro benmonro deleted the feature/fix-to-have-attribute-issue branch September 10, 2020 15:10
@benmonro
Copy link
Member Author

🎉 This PR is included in version 3.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant