Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include eslint@7 in peer dependency range #193

Closed
SimenB opened this issue Jul 5, 2020 · 3 comments
Closed

Include eslint@7 in peer dependency range #193

SimenB opened this issue Jul 5, 2020 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@SimenB
Copy link

SimenB commented Jul 5, 2020

eslint-plugin-testing-library/package.json

Lines 69 to 71 in f9f499b

"peerDependencies": {
"eslint": "^5 || ^6"
},

nickmccurdy added a commit that referenced this issue Jul 6, 2020
@nickmccurdy
fix: include eslint@7 in peer dependency range
05fda3d 
Fixes #193
@nickmccurdy nickmccurdy linked a pull request Jul 6, 2020 that will close this issue
ESLint 7 support #194
Closed
@nickmccurdy
Copy link
Member

This seems to be a duplicate of #138 and it will be fixed by #139. Mind if I close this?

@Belco90 Belco90 closed this as completed Jul 6, 2020
@Belco90 Belco90 added the duplicate This issue or pull request already exists label Jul 6, 2020
@SimenB
Copy link
Author

SimenB commented Jul 6, 2020

Ah, didn't find that somehow when searching 👍

@Belco90
Copy link
Member

Belco90 commented Sep 20, 2020

This has been finally released in v3.9.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ESLint 7 support testing-library/eslint-plugin-testing-library
3 participants
@nickmccurdy @SimenB @Belco90