New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running eslint-remote-tester-runner for each new version published #341
Comments
@MichaelDeBoey @AriPerkkio moving conversation here 馃槄 As discussed I'd go for creating a new action file in this plugin which runs the remote tester. It would be executed on each new package published (not really sure how to hook the CI to this? New tag pushed?), and just by getting a failed pipeline would be enough for us to know something went wrong linting some repo. Additionally, put the flag in our README. |
The
There's the
|
@AriPerkkio oooh I see! Even better then. I'll work on this after I get pending issues solved (unless @MichaelDeBoey wants to take care of it now) |
Here is example of integration for reference: Following the setup from first commit should be enough. When deciding which rules to include and which rule settings, try to cover as many branches of the code as possible. The configuration doesnt have to "make sense", e.g. you can mix react and angular rules in same setup. Goal is to test all rules as widely as possible. |
@AriPerkkio is it also possible to somehow export a That way we don't have to bother about all the config stuff (like This can also be something that |
I'm not really planning on providing a base configuration - the default values of configuration are for that. Ideas for improving these are definitely welcome. 馃憤 For const { getRepositories, getPathIgnorePattern } = require('eslint-remote-tester-repositories');
module.exports = {
repositories: getRepositories({ randomize: true }),
pathIgnorePattern: getPathIgnorePattern(),
cache: false, // This should probably be set by eslint-remote-tester-run-action automatically 馃
extensions: ['js', 'jsx', 'ts', 'tsx'], // This should probably be default value in eslint-remote-tester 馃
eslintrc: {
// This is really plugin specific and should not be provided by eslint-remote-tester
}
}; |
@AriPerkkio I would not suggest doing that in I'll create an issue on the repo to discuss it further there. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
馃帀 This issue has been resolved in version 5.0.1 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
@AriPerkkio I forgot to mention: another possibility would be running
eslint-remote-tester-runner
within this project without blocking the CI at all, that's up to us 馃槃 . So every time we release a new version, we trigger the remote tester runner in parallel and leave it doing its thing to get the report when gets finished. Is that possible? I guess so right?Originally posted by @Belco90 in #272 (comment)
The text was updated successfully, but these errors were encountered: