Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: await-fire-event doesn't show the fireEvent method correctly in the error message #590

Closed
Belco90 opened this issue May 19, 2022 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers released

Comments

@Belco90
Copy link
Member

Belco90 commented May 19, 2022

Have you read the Troubleshooting section?

Yes

Plugin version

v5.5.0

ESLint version

v8.14.0

Node.js version

v16.15.0

package manager and version

npm v8.9.0

Operating system

macOS v12.3.1

Bug description

Errors reported by await-fire-event rule are not indicating the fireEvent method name correctly in the message.

Steps to reproduce

test('increments value on click', async () => {
  render(App);

  expect(screen.getByText('Times clicked: 0')).toBeDefined();

  const button = screen.getByText('increment');

  fireEvent.click(button);

  expect(screen.getByText('Times clicked: 1')).toBeDefined();
});

Error output/screenshots

CleanShot 2022-05-20 at 00 14 50

ESLint configuration

N/A

Rule(s) affected

await-fire-event

Anything else?

No response

Do you want to submit a pull request to fix this bug?

No

@Belco90 Belco90 added bug Something isn't working triage Pending to be triaged by a maintainer good first issue Good for newcomers and removed triage Pending to be triaged by a maintainer labels May 19, 2022
@IvanAprea
Copy link
Contributor

Hello, can i propose a solution for this?

@Belco90
Copy link
Member Author

Belco90 commented May 20, 2022

@IvanAprea yes please! PRs are more than welcome.

@github-actions
Copy link

🎉 This issue has been resolved in version 5.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers released
Projects
None yet
Development

No branches or pull requests

2 participants