Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for {framework}-testing-library module imports #628

Open
Belco90 opened this issue Aug 4, 2022 · 5 comments
Open

Drop support for {framework}-testing-library module imports #628

Belco90 opened this issue Aug 4, 2022 · 5 comments
Labels
BREAKING CHANGE This change will require a major version bump v7 Next major v7

Comments

@Belco90
Copy link
Member

Belco90 commented Aug 4, 2022

Drop support for {framework}-testing-library module imports, in favor of supporting only the testing-library scoped format (@testing-library/{framework})

There is an exception for Marko Testing Library tho.

@MichaelDeBoey MichaelDeBoey added the BREAKING CHANGE This change will require a major version bump label Aug 4, 2022
@Belco90 Belco90 added the v6 Next major v6 label Aug 4, 2022
@MichaelDeBoey MichaelDeBoey changed the title Drop support for {framework}-testing-library module imports Drop support for {framework}-testing-library module imports Aug 4, 2022
@skovy
Copy link
Collaborator

skovy commented Oct 19, 2022

Is this primarily for no-dom-import, or does this affect other rules?

@Belco90
Copy link
Member Author

Belco90 commented Oct 19, 2022

This technically applies to all rules, since we check both import declarations and require call expressions in the detect-testing-library-utils. If you open lib/create-testing-library-rule/detect-testing-library-utils.ts in line 1036, you'll see we are detecting Testing Library imports with require() in there. We would have to remove that block entirely, and remove/update all the examples importing with require().

@skovy
Copy link
Collaborator

skovy commented Oct 20, 2022

Ah that makes sense, thanks for that additional context! I'll see if I can pick this up in the coming days/weeks

@Belco90 Belco90 self-assigned this Jan 10, 2023
@Belco90
Copy link
Member Author

Belco90 commented Jan 10, 2023

Taking care of this one.

@Belco90
Copy link
Member Author

Belco90 commented Aug 1, 2023

Back to TODO.

@Belco90 Belco90 removed their assignment Aug 1, 2023
@Belco90 Belco90 added v7 Next major v7 and removed v6 Next major v6 labels Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump v7 Next major v7
Projects
Development

No branches or pull requests

3 participants