Disallow usages of innerHTML for no-container rule #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodingItWrong
commented
Mar 18, 2024
| // messageId: 'noContainer', | ||
| // }, | ||
| // ], | ||
| // }, |
There was a problem hiding this comment.
@Belco90 This comment-out test is the test that is failing now, that shows us that we are not yet handling the view.container.innerHTML case
There was a problem hiding this comment.
I see. I need to go again through the utils for navigating the nodes, I think we had something to fix the problem described in the main description.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #889 +/- ##
==========================================
- Coverage 96.23% 96.21% -0.03%
==========================================
Files 44 44
Lines 2419 2432 +13
Branches 1000 1007 +7
==========================================
+ Hits 2328 2340 +12
- Misses 91 92 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
Changes
containerpropretyview, and then it is accessed asview.container.innerHTML. For container methods, this seems to be caught by the code on lines 95-106. But we can't use that code as-is inMemberExpression()because of the errorProperty 'callee' does not exist on type 'MemberExpression'.. Looking over our code, do you have an ideas on how we could detect theview.container.innerHTMLcase inMemberExpression()? @Belco90Context
Fixes #883