New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add exact mode option for toHaveClass (#176) #217
feat: add exact mode option for toHaveClass (#176) #217
Conversation
Sure, no problem. I didn't understand it correctly.
I think the name
In my view something like By the way, do you know why Travis' validation is failing? |
Can you bring up the naming change suggestion in the issue #176 (just so that the people that originally discuss this can chime in). I'll post my thoughts about it over there, but it kinda make sense your suggestion. Let's see what others think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thanks for this!
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 245 257 +12
Branches 59 62 +3
=========================================
+ Hits 245 257 +12
Continue to review full report at Codecov.
|
@all-contributors please add @SergiCL for code, test |
I've put up a pull request to add @SergiCL! 🎉 |
🎉 This PR is included in version 5.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Added exact mode option for toHaveClass matcher, as discussed in #176
How
If exact option is not passed or is false, it will continue working as before these changes.
Checklist: