New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(toHaveValue): Enhanced error message with type information on loose equality #219
feat(toHaveValue): Enhanced error message with type information on loose equality #219
Conversation
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 240 245 +5
Branches 58 59 +1
=========================================
+ Hits 240 245 +5
Continue to review full report at Codecov.
|
Hey guys, could you give me some advice regarding the Type Definitions and why the checks are failing? When I run |
Looks like this only fails with node 13. The branch is also out of date. Try updating it with Then you can investigate by using node 13 locally. Should throw the same error. |
I updated to node 13.11.0 and it still doesn't fail locally. Updated with |
Sorry to bother again, but when I try to commit the changes the Can you give me a hint on how to solve this? Or is it okay to use the |
No idea. I have husky disabled globally anyway. |
…hub.com/mfelmy/jest-dom into pr/enhance-error-message-of-toHaveValue
@all-contributors please add @mfelmy for code |
I've put up a pull request to add @mfelmy! 🎉 |
@mfelmy Nice work, thanks! |
🎉 This PR is included in version 5.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Thank you very much for helping me on my first pull request. |
@all-contributors please add @mfelmy for code, test |
I've put up a pull request to add @mfelmy! 🎉 |
@all-contributors please add @mfelmy for code, test |
I've put up a pull request to add @mfelmy! 🎉 |
What:
As discussed in #218 the error message of
toHaveValue
was enhanced by type information if the received and expected value have loose equality.Why:
To improve DX.
How:
The expected and received values are checked for loose equality and enhanced by type information if loose equality is given.
Checklist:
If you could point me to where I can update the Type Definitions, I would be happy to do so.