Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deep element not allowed to be disabled being returned as disabled #261

Merged
merged 1 commit into from Jun 14, 2020
Merged

Fix deep element not allowed to be disabled being returned as disabled #261

merged 1 commit into from Jun 14, 2020

Conversation

lourenci
Copy link
Contributor

Elements not allowed to be disabled are returning as disabled when inside a disabled fieldset.

<fieldset disabled>
  // <a /> is enabled even when inside a disabled fieldset
  <a />
</fieldset>
  • Documentation
  • Tests
  • Updated Type Definitions
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #261 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #261   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          313       315    +2     
  Branches        73        71    -2     
=========================================
+ Hits           313       315    +2     
Impacted Files Coverage Δ
src/to-be-disabled.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8d3095...9a2f2e4. Read the comment docs.

@gnapse gnapse merged commit 5e39222 into testing-library:master Jun 14, 2020
@gnapse
Copy link
Member

gnapse commented Jun 14, 2020

@all-contributors add @lourenci for code, test, bug

@allcontributors
Copy link
Contributor

@gnapse

I've put up a pull request to add @lourenci! 🎉

@gnapse
Copy link
Member

gnapse commented Jun 14, 2020

🎉 This PR is included in version 5.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lourenci lourenci deleted the fix-to-be-disabled branch June 14, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants